Skip to content

refactor(reactivity): remove unnecessary properties and condition #6185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(reactivity): remove unnecessary properties and condition #6185

wants to merge 1 commit into from

Conversation

javastation
Copy link
Contributor

type of the first parameter of triggerEffects is always Set, so remove isArray, and the parameter will be spread, the createDep that adds wasTracked and newTracked is unnecessary.

@skirtles-code skirtles-code mentioned this pull request Mar 5, 2023
Closed
This was referenced Aug 19, 2023
Closed
Closed
@pikax
Copy link
Member

pikax commented Oct 20, 2023

closing this in favour of #7827, since it also has this changes

@pikax pikax closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javastation @pikax