Skip to content

refactor(reactivity): remove computed SSR-specific code #10354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

refactor(reactivity): remove computed SSR-specific code #10354

wants to merge 3 commits into from

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Feb 18, 2024 •
edited
Loading

Refs #5208

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.3 kB (-119 B) 34.3 kB (-69 B) 31 kB (-17 B)
vue.global.prod.js 147 kB (-119 B) 53.6 kB (-124 B) 47.9 kB (-23 B)

Usages

Name Size Gzip Brotli
createApp 50.6 kB (-1 B) 19.8 kB (+70 B) 18 kB (-34 B)
createSSRApp 53.9 kB (-1 B) 21.1 kB (+88 B) 19.2 kB (-3 B)
defineCustomElement 52.8 kB (-1 B) 20.6 kB (+103 B) 18.7 kB (-24 B)
overall 64.2 kB (-119 B) 24.8 kB (+32 B) 22.5 kB (-30 B)

@johnsoncodehk
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 18, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ❌ failure ❌ failure
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ❌ failure ✅ success
test-utils ✅ success ✅ success
vant ❌ failure ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ❌ failure
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@yyx990803 yyx990803 mentioned this pull request Feb 24, 2024
Merged
yyx990803 added a commit that referenced this pull request Feb 25, 2024
@yyx990803
Refactor reactivity system to use version counting and doubly-linked …
05eb4e0 
…list tracking (#10397)

Bug fixes
close #10236
close #10069

PRs made stale by this one
close #10290
close #10354
close #10189
close #9480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnsoncodehk @vue-bot