Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Mar 2, 2023

This PR is to use FlashAttention kernels for multi_query_kv_attention, which performs masked attention for the prompt inputs.

Pros

  • FlashAttention is fast and memory-efficient.
  • FlashAttention supports 1D inputs and only invokes a single kernel to handle multiple sequences with variable lengths.

Cons

Besides, note that FlashAttention does not support cached KV, which is required for interactive generation.

Tested models:

  • OPT-125M
  • OPT-350M
  • OPT-1.3B
  • OPT-2.7B
  • OPT-6.7B
  • OPT-13B

Tested GPUs:

  • A100

@WoosukKwon WoosukKwon merged commit 3e9f991 into main Mar 2, 2023
@WoosukKwon WoosukKwon deleted the flash-attn branch March 2, 2023 05:13
xiangyuT added a commit to xiangyuT/vllm that referenced this pull request Oct 24, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
luo-cheng2021 pushed a commit to luo-cheng2021/vllm that referenced this pull request Mar 12, 2024
luo-cheng2021 pushed a commit to luo-cheng2021/vllm that referenced this pull request Mar 25, 2024
…o-model-executor

Adapt OpenVINO CPU plugin implementation
mzusman pushed a commit to mzusman/vllm that referenced this pull request Apr 16, 2024
BA-78760: Jamba

* Add support for n concat and splitting

* change naming

* input_metadata is a dict list now in order to pass "n"

* clean up code from unecessary changes and prints

* Remove kv cache allocation in case of mamba layer

* Add the considerations of mamba layer cache into the num of blocks
calculation

* Delete mamba cache after profile

* Remove prints

* Cleaning

* - and not _ for requirements

Approved-by: Tomer Asida
linxihui added a commit to linxihui/vllm that referenced this pull request May 14, 2024
yukavio pushed a commit to yukavio/vllm that referenced this pull request Jul 3, 2024
…ect#4

magic_wand semi_structured_sparse_tensor_linear branch integrates 2:4 semi-structured sparsity into SparseTensor. This PR adds a new sparsity config for 2:4 sparsity to neuralmagic-vllm, using the SparseTensor 2:4 support.

This PR also refactors the sparse linear method into a separate file, vllm/model_executor/layers/sparsity/sparse_w16a16_linear_method.py, which supports all sparsity formats.
yukavio pushed a commit to yukavio/vllm that referenced this pull request Jul 3, 2024
…ect#4

magic_wand semi_structured_sparse_tensor_linear branch integrates 2:4 semi-structured sparsity into SparseTensor. This PR adds a new sparsity config for 2:4 sparsity to neuralmagic-vllm, using the SparseTensor 2:4 support.

This PR also refactors the sparse linear method into a separate file, vllm/model_executor/layers/sparsity/sparse_w16a16_linear_method.py, which supports all sparsity formats.
Flechman pushed a commit to Flechman/vllm that referenced this pull request Apr 10, 2025
tlrmchlsmth referenced this pull request in tlrmchlsmth/vllm Apr 15, 2025
commit 7f57f3c
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 17:13:31 2025 +0000

    update lifecycle

    Signed-off-by: [email protected] <[email protected]>

commit 7c31e29
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 17:03:55 2025 +0000

    nits

    Signed-off-by: [email protected] <[email protected]>

commit 74af233
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:44:01 2025 +0000

    done with nits

    Signed-off-by: [email protected] <[email protected]>

commit e64f745
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:28:51 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 40e5d81
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:25:04 2025 +0000

    refactor

    Signed-off-by: [email protected] <[email protected]>

commit 25c9592
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:20:41 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit fc58dd5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:13:39 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 20decdf
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:06:15 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 5145566
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:52:03 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 62e1421
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:47:40 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 689379e
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:39:40 2025 +0000

    updaed

    Signed-off-by: [email protected] <[email protected]>

commit b1310fd
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:36:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7b64acb
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:32:47 2025 +0000

    clean up code

    Signed-off-by: [email protected] <[email protected]>

commit 7766ca5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:31:33 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit b0629bd
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:27:58 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit eca7a49
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:25:24 2025 +0000

    cleaning

    Signed-off-by: [email protected] <[email protected]>

commit 1881aa5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:24:55 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7833645
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:11:18 2025 +0000

    updared

    Signed-off-by: [email protected] <[email protected]>

commit e72e5e4
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:08:34 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 48c2eb2
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:07:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit de1e487
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:01:14 2025 +0000

    fix nit

    Signed-off-by: [email protected] <[email protected]>

commit 0163070
Merge: e2ecc14 8b3f606
Author: Robert Shaw <[email protected]>
Date:   Wed Apr 9 10:39:46 2025 -0400

    Merge pull request #4 from robertgshaw2-redhat/rob-changes

    Rob changes

commit 8b3f606
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:29:26 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 90e8c53
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:29:17 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit da019df
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:23:47 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 4ebcc3e
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:44:41 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 00df670
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:20:14 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit a73721a
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:19:17 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 31d807e
Author: [email protected] <[email protected]>
Date:   Tue Apr 8 20:58:28 2025 +0000

    stash

    Signed-off-by: [email protected] <[email protected]>

commit 5accb53
Author: [email protected] <[email protected]>
Date:   Tue Apr 8 16:00:29 2025 +0000

    stash

    Signed-off-by: [email protected] <[email protected]>

Signed-off-by: ApostaC <[email protected]>
tlrmchlsmth referenced this pull request in tlrmchlsmth/vllm Apr 15, 2025
commit 406d6bf
Author: Rémi Delacourt <[email protected]>
Date:   Fri Apr 11 00:47:40 2025 +0200

    Add MLA support for v1 disagg connector (#6)

    Signed-off-by: remi <[email protected]>

commit 1d8415d
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 21:59:54 2025 +0000

    rename

    Signed-off-by: [email protected] <[email protected]>

commit 9c4159c
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 21:41:20 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 54e1491
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 20:31:35 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 8e1eadc
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 20:26:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 05349a5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 22:10:50 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7f57f3c
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 17:13:31 2025 +0000

    update lifecycle

    Signed-off-by: [email protected] <[email protected]>

commit 7c31e29
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 17:03:55 2025 +0000

    nits

    Signed-off-by: [email protected] <[email protected]>

commit 74af233
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:44:01 2025 +0000

    done with nits

    Signed-off-by: [email protected] <[email protected]>

commit e64f745
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:28:51 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 40e5d81
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:25:04 2025 +0000

    refactor

    Signed-off-by: [email protected] <[email protected]>

commit 25c9592
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:20:41 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit fc58dd5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:13:39 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 20decdf
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:06:15 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 5145566
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:52:03 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 62e1421
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:47:40 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 689379e
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:39:40 2025 +0000

    updaed

    Signed-off-by: [email protected] <[email protected]>

commit b1310fd
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:36:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7b64acb
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:32:47 2025 +0000

    clean up code

    Signed-off-by: [email protected] <[email protected]>

commit 7766ca5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:31:33 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit b0629bd
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:27:58 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit eca7a49
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:25:24 2025 +0000

    cleaning

    Signed-off-by: [email protected] <[email protected]>

commit 1881aa5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:24:55 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7833645
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:11:18 2025 +0000

    updared

    Signed-off-by: [email protected] <[email protected]>

commit e72e5e4
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:08:34 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 48c2eb2
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:07:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit de1e487
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:01:14 2025 +0000

    fix nit

    Signed-off-by: [email protected] <[email protected]>

commit 0163070
Merge: e2ecc14 8b3f606
Author: Robert Shaw <[email protected]>
Date:   Wed Apr 9 10:39:46 2025 -0400

    Merge pull request #4 from robertgshaw2-redhat/rob-changes

    Rob changes

commit 8b3f606
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:29:26 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 90e8c53
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:29:17 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit da019df
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:23:47 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 4ebcc3e
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:44:41 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 00df670
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:20:14 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit a73721a
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:19:17 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 31d807e
Author: [email protected] <[email protected]>
Date:   Tue Apr 8 20:58:28 2025 +0000

    stash

    Signed-off-by: [email protected] <[email protected]>

commit 5accb53
Author: [email protected] <[email protected]>
Date:   Tue Apr 8 16:00:29 2025 +0000

    stash

    Signed-off-by: [email protected] <[email protected]>

Signed-off-by: ApostaC <[email protected]>
tlrmchlsmth referenced this pull request in tlrmchlsmth/vllm Apr 15, 2025
commit 3a24897
Author: ApostaC <[email protected]>
Date:   Thu Apr 10 18:31:47 2025 -0700

    [Fix] memory leak problem by proper clean up

    Signed-off-by: ApostaC <[email protected]>

commit 406d6bf
Author: Rémi Delacourt <[email protected]>
Date:   Fri Apr 11 00:47:40 2025 +0200

    Add MLA support for v1 disagg connector (#6)

    Signed-off-by: remi <[email protected]>

commit 1d8415d
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 21:59:54 2025 +0000

    rename

    Signed-off-by: [email protected] <[email protected]>

commit 9c4159c
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 21:41:20 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 54e1491
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 20:31:35 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 8e1eadc
Author: [email protected] <[email protected]>
Date:   Thu Apr 10 20:26:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 05349a5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 22:10:50 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7f57f3c
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 17:13:31 2025 +0000

    update lifecycle

    Signed-off-by: [email protected] <[email protected]>

commit 7c31e29
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 17:03:55 2025 +0000

    nits

    Signed-off-by: [email protected] <[email protected]>

commit 74af233
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:44:01 2025 +0000

    done with nits

    Signed-off-by: [email protected] <[email protected]>

commit e64f745
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:28:51 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 40e5d81
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:25:04 2025 +0000

    refactor

    Signed-off-by: [email protected] <[email protected]>

commit 25c9592
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:20:41 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit fc58dd5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:13:39 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 20decdf
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 16:06:15 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 5145566
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:52:03 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 62e1421
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:47:40 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 689379e
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:39:40 2025 +0000

    updaed

    Signed-off-by: [email protected] <[email protected]>

commit b1310fd
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:36:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7b64acb
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:32:47 2025 +0000

    clean up code

    Signed-off-by: [email protected] <[email protected]>

commit 7766ca5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:31:33 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit b0629bd
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:27:58 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit eca7a49
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:25:24 2025 +0000

    cleaning

    Signed-off-by: [email protected] <[email protected]>

commit 1881aa5
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:24:55 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 7833645
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:11:18 2025 +0000

    updared

    Signed-off-by: [email protected] <[email protected]>

commit e72e5e4
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:08:34 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 48c2eb2
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:07:37 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit de1e487
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 15:01:14 2025 +0000

    fix nit

    Signed-off-by: [email protected] <[email protected]>

commit 0163070
Merge: e2ecc14 8b3f606
Author: Robert Shaw <[email protected]>
Date:   Wed Apr 9 10:39:46 2025 -0400

    Merge pull request #4 from robertgshaw2-redhat/rob-changes

    Rob changes

commit 8b3f606
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:29:26 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 90e8c53
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:29:17 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit da019df
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 14:23:47 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 4ebcc3e
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:44:41 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 00df670
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:20:14 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit a73721a
Author: [email protected] <[email protected]>
Date:   Wed Apr 9 13:19:17 2025 +0000

    updated

    Signed-off-by: [email protected] <[email protected]>

commit 31d807e
Author: [email protected] <[email protected]>
Date:   Tue Apr 8 20:58:28 2025 +0000

    stash

    Signed-off-by: [email protected] <[email protected]>

commit 5accb53
Author: [email protected] <[email protected]>
Date:   Tue Apr 8 16:00:29 2025 +0000

    stash

    Signed-off-by: [email protected] <[email protected]>

Signed-off-by: ApostaC <[email protected]>
yyu6969 pushed a commit to yyu6969/vllm that referenced this pull request Apr 26, 2025
zhaoyifan222 added a commit to LookAround0301/vllm that referenced this pull request Sep 11, 2025
yuz207 added a commit to IluvatarLabs/vllm that referenced this pull request Sep 30, 2025
Add diagnostic logging to verify draft_top_p value and whether nucleus
will execute.

This will help diagnose why nucleus shows 32000 survivors (full vocab)
instead of filtered set.

Expected log output:
[NUCLEUS_DEBUG] draft_top_p from config: 0.95, will run nucleus: True

If we see 'will run nucleus: False', we'll know the config isn't loaded
or there's a logic bug in the condition.
yuz207 added a commit to IluvatarLabs/vllm that referenced this pull request Sep 30, 2025
…thing diagnostics

Bug vllm-project#4 fix: Change nucleus top_p fallback from 1.0 to 0.95, add
[NUCLEUS_DEBUG] diagnostic logging. This ensures nucleus runs even if
config attribute is missing, preventing 32000 survivors (full vocab).

Bug vllm-project#5 fix: Add [SMOOTH_DEBUG] diagnostic logging for smoothing lambda.

These fixes were accidentally removed during the bug vllm-project#2 draft-anchored
rewrite (commit 595a371). Restoring them does not affect bug vllm-project#2's
core algorithm - they only improve fallback behavior and diagnostics.
dcmaddix pushed a commit to dcmaddix/vllm that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant