-
Notifications
You must be signed in to change notification settings - Fork 467
Multimodality Scenarios Sample Deployment #1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Multimodality Scenarios Sample Deployment #1584
Conversation
Summary of ChangesHello @happyandslow, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the multimodality capabilities by adding comprehensive Kubernetes deployment configurations for various advanced AI models. It aims to streamline the deployment and management of these models, enabling easier experimentation and production use of large language, vision, audio, and diffusion models within the existing infrastructure. The changes also include minor updates to image references for consistency and reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a collection of Kubernetes deployment files for various multi-modality models. While the additions are valuable for demonstration purposes, the review has identified several recurring issues across the new YAML files that should be addressed to improve correctness, security, and maintainability. Key concerns include the use of hostPath
volumes which poses security risks, inconsistencies in naming conventions, inefficient container startup practices like installing packages at runtime, and general YAML formatting issues. Addressing these points will make the samples more robust and better examples of production-ready configurations.
- name: model-hostpath | ||
hostPath: | ||
path: /root/models | ||
type: DirectoryOrCreate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using hostPath
volumes introduces security risks and makes the deployment less portable, as it depends on a specific path (/root/models
) existing on the node. It's highly recommended to use a PersistentVolumeClaim
(PVC) for storing models. This decouples storage from the node and is a more standard and secure practice in Kubernetes.
Example of using a PVC:
First, create a PersistentVolumeClaim
:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: model-storage-pvc
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 50Gi # Adjust size as needed
Then, use it in your deployment:
volumes:
- name: model-hostpath
persistentVolumeClaim:
claimName: model-storage-pvc
c4eb796
to
afbb91e
Compare
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
9cb845b
to
c34d3eb
Compare
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Pull Request Description
This PR tracks multi-modality use cases/demo deployment files and scripts
Related Issues
Resolves: #1509