-
Notifications
You must be signed in to change notification settings - Fork 29.5k
[test] Ignore pnpm update notifier #84328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Ignore pnpm update notifier #84328
Conversation
- 'turbopack/crates/*/js' | ||
- 'turbopack/crates/turbopack-tests/tests/execution' | ||
- 'turbopack/packages/*' | ||
updateNotifier: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests Passed |
- 'turbopack/crates/*/js' | ||
- 'turbopack/crates/turbopack-tests/tests/execution' | ||
- 'turbopack/packages/*' | ||
updateNotifier: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updateNotifier: false
configuration is not a valid option for pnpm-workspace.yaml
and will be ignored by pnpm.
View Details
📝 Patch Details
diff --git a/.npmrc b/.npmrc
index 54d9bd55d4..e51d0edc6e 100644
--- a/.npmrc
+++ b/.npmrc
@@ -4,4 +4,5 @@ link-workspace-packages = true
provenance = true
save-exact = true
strict-peer-dependencies = false
-tag-version-prefix=""
\ No newline at end of file
+tag-version-prefix=""
+update-notifier = false
\ No newline at end of file
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index 177abe373f..947946c7aa 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -6,4 +6,3 @@ packages:
- 'turbopack/crates/*/js'
- 'turbopack/crates/turbopack-tests/tests/execution'
- 'turbopack/packages/*'
-updateNotifier: false
Analysis
Invalid updateNotifier configuration in pnpm-workspace.yaml ignored by pnpm
What fails: The updateNotifier: false
configuration in pnpm-workspace.yaml is not a valid workspace option and is silently ignored by pnpm, failing to suppress update notifications as intended
How to reproduce:
# Check pnpm configuration with updateNotifier in workspace file
pnpm config get update-notifier
# Returns: undefined (setting is ignored)
Result: Update notifications will still appear during pnpm operations despite the updateNotifier: false
setting
Expected: The setting should suppress update notifications. Per pnpm .npmrc documentation, update-notifier
is a valid configuration option that should be placed in .npmrc
, not pnpm-workspace.yaml
. The pnpm-workspace.yaml documentation only lists packages
and catalog
as valid options.
Fix: Moved updateNotifier: false
from pnpm-workspace.yaml to .npmrc
as update-notifier = false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two files documenting pnpm-workspace.yaml
. The one you linked that doesn't list it. And one just for settings that does list it: https://pnpm.io/settings#updatenotifier
This notification even pops up in our e2e test:
I'd consider this message noise. If we want to be notified of updates, we can subscribe to pnpm release. Constantly notifying is annoying.