Skip to content

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 29, 2025

This notification even pops up in our e2e test:

╭───────────────────────────────────────────────────────────────╮
│                                                               |
│              Update available! 8.15.7 → 10.17.1.              │
│                                                               |
|                          Changelog:                           │
│      https://github.com/pnpm/pnpm/releases/tag/v10.17.1       │
│   Run "corepack prepare [email protected] --activate" to update.   │
│                                                               │
│    Follow @pnpmjs for updates: https://twitter.com/pnpmjs     │
│                                                               │
╰───────────────────────────────────────────────────────────────╯

I'd consider this message noise. If we want to be notified of updates, we can subscribe to pnpm release. Constantly notifying is annoying.

@eps1lon eps1lon requested a review from unstubbable September 29, 2025 08:14
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Sep 29, 2025
- 'turbopack/crates/*/js'
- 'turbopack/crates/turbopack-tests/tests/execution'
- 'turbopack/packages/*'
updateNotifier: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon eps1lon marked this pull request as ready for review September 29, 2025 08:14
@ijjk
Copy link
Member

ijjk commented Sep 29, 2025

Tests Passed

- 'turbopack/crates/*/js'
- 'turbopack/crates/turbopack-tests/tests/execution'
- 'turbopack/packages/*'
updateNotifier: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updateNotifier: false configuration is not a valid option for pnpm-workspace.yaml and will be ignored by pnpm.

View Details
📝 Patch Details
diff --git a/.npmrc b/.npmrc
index 54d9bd55d4..e51d0edc6e 100644
--- a/.npmrc
+++ b/.npmrc
@@ -4,4 +4,5 @@ link-workspace-packages = true
 provenance = true
 save-exact = true
 strict-peer-dependencies = false
-tag-version-prefix=""
\ No newline at end of file
+tag-version-prefix=""
+update-notifier = false
\ No newline at end of file
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index 177abe373f..947946c7aa 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -6,4 +6,3 @@ packages:
   - 'turbopack/crates/*/js'
   - 'turbopack/crates/turbopack-tests/tests/execution'
   - 'turbopack/packages/*'
-updateNotifier: false

Analysis

Invalid updateNotifier configuration in pnpm-workspace.yaml ignored by pnpm

What fails: The updateNotifier: false configuration in pnpm-workspace.yaml is not a valid workspace option and is silently ignored by pnpm, failing to suppress update notifications as intended

How to reproduce:

# Check pnpm configuration with updateNotifier in workspace file
pnpm config get update-notifier
# Returns: undefined (setting is ignored)

Result: Update notifications will still appear during pnpm operations despite the updateNotifier: false setting

Expected: The setting should suppress update notifications. Per pnpm .npmrc documentation, update-notifier is a valid configuration option that should be placed in .npmrc, not pnpm-workspace.yaml. The pnpm-workspace.yaml documentation only lists packages and catalog as valid options.

Fix: Moved updateNotifier: false from pnpm-workspace.yaml to .npmrc as update-notifier = false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two files documenting pnpm-workspace.yaml. The one you linked that doesn't list it. And one just for settings that does list it: https://pnpm.io/settings#updatenotifier

@eps1lon eps1lon merged commit dbaa85f into canary Sep 29, 2025
303 of 307 checks passed
Copy link
Member Author

eps1lon commented Sep 29, 2025

Merge activity

@eps1lon eps1lon deleted the sebbie/09-29-_test_ignore_pnpm_update_notifier branch September 29, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants