Skip to content

fix: correct typo 'incomming' to 'incoming' in with-mqtt-js example #83887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2025
Merged

fix: correct typo 'incomming' to 'incoming' in with-mqtt-js example #83887

merged 3 commits into from
Sep 17, 2025
+8 −11

Conversation

ericx0099
Copy link
Contributor

What?

This PR fixes a typo in the with-mqtt-js example (examples/with-mqtt-js/app/page.tsx):
all occurrences of "incomming" have been corrected to "incoming" in variables, refs, and JSX headings.

Why?

The previous spelling "incomming" is incorrect in English. Correcting it improves readability and professionalism in the example code.

How?

  • Renamed incommingMessages → incomingMessages
  • Renamed setIncommingMessages → setIncomingMessages
  • Renamed incommingMessageHandlers → incomingMessageHandlers
  • Updated JSX headings and references accordingly

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 17, 2025
@ijjk
Copy link
Member

ijjk commented Sep 17, 2025 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: d2bf84c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

icyJoseph
icyJoseph approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@icyJoseph icyJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting key choice we had there, and also the typing.... anyway, non-blocking stuff.

@icyJoseph
Copy link
Contributor

@ericx0099 please run pnpm prettier-fix to fix examples/with-mqtt-js/app/page.tsx

@icyJoseph icyJoseph self-requested a review September 17, 2025 13:29
@ericx0099
Copy link
Contributor Author

@ericx0099 please run pnpm prettier-fix to fix examples/with-mqtt-js/app/page.tsx

Done

@ijjk ijjk merged commit bc9fe49 into vercel:canary Sep 17, 2025
65 checks passed
@github-actions github-actions bot added the locked label Oct 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@icyJoseph icyJoseph Awaiting requested review from icyJoseph

Assignees
No one assigned
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericx0099 @ijjk @icyJoseph