Setting NODE_ENV to 'staging' causes builds to fail

[pjaws]

Bug report

Describe the bug

Setting NODE_ENV to 'staging' causes next build to fail on a Webpack "unexpected token" error - presumably the first time it encounters JSX.

To Reproduce

1. Create a Next.js app with JSX in it
2. NODE_ENV=staging npm run build
3. ?????
4. Failure

Expected behavior

Probably shouldn't fail.

Screenshots

System information

• OS: macOS, whatever Linux Heroku runs
• Version of Next.js: 9.2.0

Additional context

Add any other context about the problem here.

[ijjk]

Hi, setting NODE_ENV to staging instead of the default values we set is not ideal as this will cause things to potentially mismatch

One case of where this will cause problems is when bundling react if you set NODE_ENV to a value other than production during a production build the development bundle will be used, see here for related code

EDIT:
It looks we override this value during bundling so the above isn't a concern although can lead to mismatches due to not overriding with next start or when loading Babel or Next configs

[rafaelalmeidatk]

Complementing the above answer: if you want to distinguish between dev, staging and production, you need to create your own environment variable, like "DEPLOY_STAGE", "PROJECT_ENV", something like that. NODE_ENV is utilized by a lot of tools to decide if it needs to optimize the code, and you want to optimize it in both staging and production environments, so the two vars can't be the same thing.

[pjaws]

Yeah I’m doing that now. Thanks!

…

On Sat, Jan 18, 2020 at 9:40 AM Rafael Almeida ***@***.***> wrote: Complementing the above answer: if you want to distinguish between dev, staging and production, you need to create your own environment variable, like "DEPLOY_STAGE", "PROJECT_ENV", something like that. NODE_ENV is utilized by a lot of tools to decide if it needs to optimize the code, and you want to optimize it in both staging and production environments, so the two vars can't be the same thing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10129>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMVRRIVW74N7QDYT245KP2TQ6M5JTANCNFSM4KHY5WAQ> .

[Manikanta-20]

@Timer any one can provide example for this?

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.