Skip to content

Conversation

Jennievon
Copy link
Contributor

Description

This PR updates the asset list in vck to use the updated token list from VeChain token registry

Image

Closes #410

Updated packages (if any):

  • next-template
  • homepage
  • vechain-kit
  • contracts

- add token registry service to fetch token data from VeChain registry
- create hooks for accessing registry tokens with metadata (name, icon, decimals)
- update `useTokenBalances` to include token metadata from registry
- support all registry tokens (50+) instead of hardcoded 6 tokens
- backward compatibility with existing token balance fetching
 - uses registry icons when available / fall back to hardcoded SVG components for core tokens
…age custom tokens) and token icons

- replace footer with floating action button for custom tokens
- add `"All tokens are VIP-180 compatible on VeChain"` disclaimer on asset list
- simplify AssetButton layout
@Jennievon Jennievon linked an issue Sep 2, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Sep 2, 2025

🚀 Preview environment deployed!

Preview URL: https://preview.vechainkit.vechain.org/410-request---add-token-details-from-token-registry

@Jennievon Jennievon requested a review from a team September 2, 2025 08:29
@Jennievon Jennievon changed the title 410: add token details from token registry add token details from token registry Sep 2, 2025
@Agilulfo1820
Copy link
Member

Agilulfo1820 commented Sep 2, 2025

image

Some tokens are missing, also VET is not an erc20 (and is missing) and I think we need to do something custom for the veDelegate balance as well

I'm rendering all the tokens from the registry. What token did you notice missing aside from VET for you, ie it's not there when you also search the list?

@Agilulfo1820
Copy link
Member

Prices are broken as well

@Agilulfo1820
Copy link
Member

From a style pov we can remove the "All tokens are VIP-180 compatible on VeChain" and I'm not super convinced about the edit button. We do not actually edit/customize the tokens we see in that list, it's only for adding tokens that are not present there. Maybe we add an "add" button near the search input?

@Jennievon
Copy link
Contributor Author

From a style pov we can remove the "All tokens are VIP-180 compatible on VeChain" and I'm not super convinced about the edit button. We do not actually edit/customize the tokens we see in that list, it's only for adding tokens that are not present there. Maybe we add an "add" button near the search input?

okay, will remove the disclaimer at the top.

For the edit button, probably better to have a + icon. It's meant for "add custom token", hence, the aria-label. But I think the add/+ beside the search bar works better considering it's fixed during scroll.

@Agilulfo1820 Agilulfo1820 marked this pull request as draft September 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Add token details from token registry
2 participants