-
Notifications
You must be signed in to change notification settings - Fork 6
add token details from token registry #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add token details from token registry #436
Conversation
- add token registry service to fetch token data from VeChain registry - create hooks for accessing registry tokens with metadata (name, icon, decimals) - update `useTokenBalances` to include token metadata from registry - support all registry tokens (50+) instead of hardcoded 6 tokens - backward compatibility with existing token balance fetching
- uses registry icons when available / fall back to hardcoded SVG components for core tokens
…age custom tokens) and token icons - replace footer with floating action button for custom tokens - add `"All tokens are VIP-180 compatible on VeChain"` disclaimer on asset list - simplify AssetButton layout
🚀 Preview environment deployed!Preview URL: https://preview.vechainkit.vechain.org/410-request---add-token-details-from-token-registry |
Prices are broken as well |
From a style pov we can remove the "All tokens are VIP-180 compatible on VeChain" and I'm not super convinced about the edit button. We do not actually edit/customize the tokens we see in that list, it's only for adding tokens that are not present there. Maybe we add an "add" button near the search input? |
okay, will remove the disclaimer at the top. For the edit button, probably better to have a |
Description
This PR updates the asset list in vck to use the updated token list from VeChain token registry
Closes #410
Updated packages (if any):