Skip to content

Conversation

jduo
Copy link
Collaborator

@jduo jduo commented Oct 2, 2025

  • Support the database_id parameter when constructing ValkeyGlideCluster instances.
  • Make the database_id field part of the base configuration instead of only standalone in the extension code.
  • Simplify the extension code to eliminate the standalone-specific configuration object.
  • Update unit tests to validate the database_id in cluster mode.
  • Validate that the supplied database_id is between 0 and 15 inclusive.
  • Update valkey-glide to commit 81079af701e6d1d24028d4414736709fc342acd1.
  • Fix patching of types.rs to address valkey-glide changes.

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

jduo added 16 commits October 2, 2025 13:16
Signed-off-by: James Duong <[email protected]>
Signed-off-by: James Duong <[email protected]>
Signed-off-by: James Duong <[email protected]>
Signed-off-by: James Duong <[email protected]>
Signed-off-by: James Duong <[email protected]>
@jduo jduo requested a review from yipin-chen October 4, 2025 13:00
Copy link
Collaborator

@asafpamzn asafpamzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good,
You disabled some tests of select and move can you revive them after this PR or do we need changes at the core?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants