feat(isMobilePhone): add Maldives dv-MV locale #1829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1829 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2029 2029
Branches 457 457
=========================================
Hits 2029 2029
Continue to review full report at Codecov.
|
|
Hi, @tux-tn can you please review this PR? Also this is part of my hacktoberfest, can you add the label for it. Thanks 😄 |
tux-tn
requested changes
Oct 27, 2021
tux-tn
added
🎉 first-pr
🧹 needs-update
beprajwal
force-pushed
the
add-maldives-mobile-phone-locale
branch
from
b80cefd to
e0172fb
Compare
beprajwal
force-pushed
the
add-maldives-mobile-phone-locale
branch
from
e0172fb to
7a70ddb
Compare
tux-tn
approved these changes
Oct 28, 2021
tux-tn
added
hacktoberfest-accepted
ready-to-land
|
@Prajwalrajbasnet -- pls fix the merge conflicts and we should be good to go. Thanks! |
profnandaa
added
the
mc-to-land
profnandaa
changed the title
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
chore: squashed #1829 Add locale for Maldives in mobile phone validator Add tests for mobile numbers validation of maldives locale i.e. dv-MV Update readme to add Maldives locale (dv-MV) in isMobilePhone documentation
|
No worries, your commit is now included here #1851 |
profnandaa
pushed a commit
that referenced
this pull request
Oct 31, 2021
chore: squashed #1829 Add locale for Maldives in mobile phone validator Add tests for mobile numbers validation of maldives locale i.e. dv-MV Update readme to add Maldives locale (dv-MV) in isMobilePhone documentation
Thanks @profnandaa, sorry for late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regex to validate Maldives mobile phone numbers.
Related to #1761
Checklist