Skip to content

feat: improve accessibility based on ARIA 1.2 #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 5, 2021
Merged

feat: improve accessibility based on ARIA 1.2 #2745

merged 7 commits into from
Oct 5, 2021

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Oct 5, 2021 •
edited
Loading

Description

Fixes #2483
Fixes #1338
Fixes #1341
Fixes #1350 (as we remove the timeout)

Type of change

  • Feature

@web-padawan web-padawan added the a11y Accessibility issue label Oct 5, 2021
@web-padawan web-padawan requested a review from tomivirkki October 5, 2021 11:25
tomivirkki
tomivirkki reviewed Oct 5, 2021
View reviewed changes
packages/vaadin-combo-box/src/vaadin-combo-box-scroller.js
el.setAttribute('theme', this.theme);
} else {
el.removeAttribute('theme');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since aria-setsize was added and virtual scrolling is used, el.setAttribute('aria-posinset', index); also needs to be applied so that the announced index is correct also on the items at the end of the set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...even with aria-posinset there seems to be some oddities with announcing the proper index

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the first item is announced as "1 of 200" (1-based index) but the last item announces as "199 of 200" (0-based index)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted #2747 to investigate if we can fix this later.

tomivirkki
tomivirkki approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than #2745 (comment), lgtm

This was referenced Oct 5, 2021
Closed
Open
@web-padawan
Copy link
Member Author

Reported #2748 and #2749 to investigate remaining issues. These aren't blockers as the behavior in VoiceOver is not any worse after this PR is merged. On the positive side, other issues like #1338 and #1341 seem to be fixed by this PR.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 26c55e0 into master Oct 5, 2021
@web-padawan web-padawan deleted the fix/combo-box-aria branch October 5, 2021 15:24
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version.

@web-padawan web-padawan mentioned this pull request Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
a11y Accessibility issue prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha7
Projects
None yet
Milestone
No milestone
3 participants
@web-padawan @vaadin-bot @tomivirkki