chore: Add GitHub Actions workflow for PR validation #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces TeamCity PR validation build with GitHub Actions workflow. Includes Maven build, test execution with Sauce Labs integration, and artifact collection for test failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Test Results 153 files 153 suites 14m 38s ⏱️ Results for commit f60ac1a. ♻️ This comment has been updated with latest results. |
…ariable - Upgrade Sauce Connect from 4.9.2 to 5.2.0 - Update command-line arguments to use new v5 syntax (--username, --access-key, --tunnel-name) - Configure TB_LICENSE secret as PRO_KEY environment variable - Remove inline license parameter from Maven command 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix URL to include version in path: /sauce-connect/{VERSION}/sauce-connect-{VERSION}_linux.x86_64.tar.gz
- Update to latest version 5.2.3
- Fix extracted directory path (./sauce-connect/sc instead of ./sauce-connect-{VERSION}/sc)
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Add format-check job to validation workflow to run in parallel with build-and-test - Remove separate format-check.yml workflow file - Format validation now runs as part of the main PR validation pipeline 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add Maven dependency caching to format-check job - Uses same cache key as build-and-test job for artifact sharing - Prevents redundant downloads between parallel jobs 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add 'needs: format-check' to build-and-test job - Ensures proper cache sharing between jobs - Prevents cache conflicts and race conditions - Format check must pass before build and tests run 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
guess this is related to jackson. we can fix it in another PR. @mshabarov |
|
Yes, Jackson 3 related failures should be fixed now. |
The extracted directory structure for Sauce Connect 5.x is
sc-${VERSION}-linux/bin/sc, not sauce-connect/sc
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Use hardcoded version in path (5.2.3) instead of variable expansion - Wait for specific "Sauce Connect is up" message instead of sleeping - Fail fast if SC process dies or doesn't start within 2 minutes - Save PID for proper cleanup - Include SC logs in failure artifacts for debugging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace manual Sauce Connect download and setup with saucelabs/sauce-connect-action@v3 - Remove manual cleanup step as the action handles it automatically - Simplify tunnel ID management - Remove sc.log from artifacts as it's not generated with the action 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Split test artifacts into two separate uploads: - error-screenshots: Contains only screenshot files from test failures - test-reports: Contains surefire and failsafe reports This makes it easier to find and download just the screenshots when debugging failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add --proxy-localhost flag to allow Sauce Labs to connect to localhost addresses, which is required for the test setup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace scArgs with the proper proxyLocalhost: allow parameter to enable localhost proxying in Sauce Connect tunnel. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Change file patterns to only include TEST-*.xml files, excluding failsafe-summary.xml which is not in JUnit XML format and causes the test result publisher to fail. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Should work now |
mshabarov
approved these changes
Sep 29, 2025
ZheSun88
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces TeamCity PR validation build with GitHub Actions workflow. Includes Maven build, test execution with Sauce Labs integration, and artifact collection for test failures.