Skip to content

Feature/issue 134 change pref defaults #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2022
Merged

Feature/issue 134 change pref defaults #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32fd6e2
change test case for default values of realtime reporter preferences …
PhilippSalvisberg Feb 26, 2022
582b8a3
closes #134 - new default values of realtime reporter preferences acc…
PhilippSalvisberg Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sqldev/src/main/java/org/utplsql/sqldev/model/preference/PreferenceModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,39 +172,39 @@ public void setNumberOfRunsInHistory(final int runs) {
}

public boolean isShowDisabledCounter() {
return getHashStructure().getBoolean(KEY_SHOW_DISABLED_COUNTER, false);
return getHashStructure().getBoolean(KEY_SHOW_DISABLED_COUNTER, true);
}

public void setShowDisabledCounter(final boolean showDisabledCounter) {
getHashStructure().putBoolean(KEY_SHOW_DISABLED_COUNTER, showDisabledCounter);
}

public boolean isShowWarningsCounter() {
return getHashStructure().getBoolean(KEY_SHOW_WARNINGS_COUNTER, false);
return getHashStructure().getBoolean(KEY_SHOW_WARNINGS_COUNTER, true);
}

public void setShowWarningsCounter(final boolean showWarningCounter) {
getHashStructure().putBoolean(KEY_SHOW_WARNINGS_COUNTER, showWarningCounter);
}

public boolean isShowInfoCounter() {
return getHashStructure().getBoolean(KEY_SHOW_INFO_COUNTER, false);
return getHashStructure().getBoolean(KEY_SHOW_INFO_COUNTER, true);
}

public void setShowInfoCounter(final boolean showInfoCounter) {
getHashStructure().putBoolean(KEY_SHOW_INFO_COUNTER, showInfoCounter);
}

public boolean isShowWarningIndicator() {
return getHashStructure().getBoolean(KEY_SHOW_WARNING_INDICATOR, false);
return getHashStructure().getBoolean(KEY_SHOW_WARNING_INDICATOR, true);
}

public void setShowWarningIndicator(final boolean showWarningIndicator) {
getHashStructure().putBoolean(KEY_SHOW_WARNING_INDICATOR, showWarningIndicator);
}

public boolean isShowInfoIndicator() {
return getHashStructure().getBoolean(KEY_SHOW_INFO_INDICATOR, false);
return getHashStructure().getBoolean(KEY_SHOW_INFO_INDICATOR, true);
}

public void setShowInfoIndicator(final boolean showInfoIndicator) {
Expand All @@ -228,7 +228,7 @@ public void setShowDisabledTests(final boolean showDisabledTests) {
}

public boolean isShowTestDescription() {
return getHashStructure().getBoolean(KEY_SHOW_TEST_DESCRIPTION, false);
return getHashStructure().getBoolean(KEY_SHOW_TEST_DESCRIPTION, true);
}

public void setShowTestDescription(final boolean showTestDescription) {
Expand Down
12 changes: 6 additions & 6 deletions sqldev/src/test/java/org/utplsql/sqldev/test/preference/PreferenceModelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ public void defaultValues() {
Assert.assertFalse(model.isCheckRunUtplsqlTest());
Assert.assertFalse(model.isUseSmartTimes());
Assert.assertEquals(10, model.getNumberOfRunsInHistory());
Assert.assertFalse(model.isShowDisabledCounter());
Assert.assertFalse(model.isShowWarningsCounter());
Assert.assertFalse(model.isShowInfoCounter());
Assert.assertFalse(model.isShowWarningIndicator());
Assert.assertFalse(model.isShowInfoIndicator());
Assert.assertTrue(model.isShowDisabledCounter());
Assert.assertTrue(model.isShowWarningsCounter());
Assert.assertTrue(model.isShowInfoCounter());
Assert.assertTrue(model.isShowWarningIndicator());
Assert.assertTrue(model.isShowInfoIndicator());
Assert.assertTrue(model.isShowSuccessfulTests());
Assert.assertTrue(model.isShowDisabledTests());
Assert.assertFalse(model.isShowTestDescription());
Assert.assertTrue(model.isShowTestDescription());
Assert.assertTrue(model.isSyncDetailTab());
Assert.assertTrue(model.isShowSuites());
Assert.assertEquals("test_", model.getTestPackagePrefix());
Expand Down