Fix safety issue in ZeroVec::truncated; publish 0.11.4 #6805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback. |
Introduced by unicode-org#6604
Manishearth
force-pushed
the
zv-truncate-safety
branch
from
f969070 to
5c8b93a
Compare
robertbastian
approved these changes
Aug 5, 2025
sffc
approved these changes
Aug 5, 2025
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Aug 14, 2025
Although imported ICU4X crates don't use truncated method in zerovec, we would like to update zerovec to fix unicode-org/icu4x#6805 as safety issue. Differential Revision: https://phabricator.services.mozilla.com/D260776
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Aug 16, 2025
Although imported ICU4X crates don't use truncated method in zerovec, we would like to update zerovec to fix unicode-org/icu4x#6805 as safety issue. Differential Revision: https://phabricator.services.mozilla.com/D260776 UltraBlame original commit: 1bd477f4b47912ab752a295ffbbc0d2b2eca7946
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Aug 16, 2025
Although imported ICU4X crates don't use truncated method in zerovec, we would like to update zerovec to fix unicode-org/icu4x#6805 as safety issue. Differential Revision: https://phabricator.services.mozilla.com/D260776 UltraBlame original commit: 1bd477f4b47912ab752a295ffbbc0d2b2eca7946
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Aug 16, 2025
Although imported ICU4X crates don't use truncated method in zerovec, we would like to update zerovec to fix unicode-org/icu4x#6805 as safety issue. Differential Revision: https://phabricator.services.mozilla.com/D260776 UltraBlame original commit: 1bd477f4b47912ab752a295ffbbc0d2b2eca7946
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Aug 20, 2025
Although imported ICU4X crates don't use truncated method in zerovec, we would like to update zerovec to fix unicode-org/icu4x#6805 as safety issue. Differential Revision: https://phabricator.services.mozilla.com/D260776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #6604
cc @hsivonen @robertbastian