Skip to content

Refactor units provider structure by renaming modules #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Refactor units provider structure by renaming modules #6738

wants to merge 17 commits into from

Conversation

younies
Copy link
Member

@younies younies commented Jul 8, 2025 •
edited
Loading

Description

  • Renamed display_name module to display_names and UnitsDisplayName to UnitsDisplayNames for better naming.
  • Updated references throughout the codebase to reflect the new namings.

@younies
Refactor units provider structure by renaming modules and adding new …
42887ff 
…folder for units (unicode-org#6734)

# Description

- Renamed `units_essentials` to `units::essentials` and `units` to `units::display_names` for better organization.
- Introduced new files for `UnitsDisplayName` and `UnitsEssentials` data structures.
- Updated references throughout the codebase to reflect the new module structure.
@younies younies requested review from sffc, robertbastian, Manishearth and a team as code owners July 8, 2025 17:13
@gemini-code-assist Gemini Code Assist
Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

robertbastian
robertbastian previously approved these changes Jul 9, 2025
View reviewed changes
robertbastian
robertbastian reviewed Jul 9, 2025
View reviewed changes
components/experimental/src/dimension/provider/units/display_names.rs Outdated
UnitsDisplayName<'static>,
#[cfg(feature = "datagen")]
attributes_domain = "units"
attributes_domain = "display_names"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a global namespace, so just display_names is wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@younies younies closed this Jul 9, 2025
@younies younies reopened this Jul 9, 2025
@younies younies closed this Jul 9, 2025
@younies younies reopened this Jul 9, 2025
sffc
sffc reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to be moving things around. OK.

@sffc
Copy link
Member

sffc commented Aug 7, 2025

@younies Do you plan to fix CI and merge this PR?

@younies younies closed this Sep 27, 2025
@younies younies reopened this Sep 29, 2025
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@younies younies marked this pull request as draft September 29, 2025 12:53
@younies younies marked this pull request as ready for review September 29, 2025 13:03
robertbastian
robertbastian reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either the PR title is wrong or the PR is incomplete. all I see here is that you rename DisplayName to DisplayNames in a couple of places, there is no new folder

components/experimental/src/dimension/provider/units/pattern_key.rs Outdated
#[cfg_attr(feature = "serde", derive(serde::Deserialize))]
#[cfg_attr(feature = "datagen", derive(serde::Serialize, databake::Bake))]
#[cfg_attr(feature = "datagen", databake(path = icu_experimental::dimension::provider::pattern_key))]
#[cfg_attr(feature = "datagen", databake(path = icu_experimental::dimension::provider::units::pattern_key))]
Copy link
Member

@robertbastian robertbastian Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this unused code? the type doesn't move, how can its bake path change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is used int components/experimental/src/dimension/provider/units/essentials.rs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used through ZeroMap, so you can actually remove the Bake implementation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

robertbastian
robertbastian approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the PR title before merging

@younies younies changed the title Refactor units provider structure by renaming modules and adding new folder for units Refactor units provider structure by renaming modules Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@robertbastian robertbastian robertbastian approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth Manishearth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@younies @sffc @CLAassistant @robertbastian