Skip to content

Refactor size_test_macro and use it in icu_decimal #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

Refactor size_test_macro and use it in icu_decimal #5805

merged 1 commit into from
Nov 12, 2024

Conversation

sffc
Copy link
Member

@sffc sffc commented Nov 12, 2024

Test for #4437

@sffc sffc requested a review from Manishearth November 12, 2024 02:16
@sffc sffc requested a review from zbraniecki as a code owner November 12, 2024 02:16
@sffc
Copy link
Member Author

sffc commented Nov 12, 2024 •
edited
Loading

I didn't implement icu4x_shared (#4467, #5101) because I didn't want this PR to be controversial. It should merge before #5804 so we can measure the size improvement.

@sffc sffc merged commit 09fde64 into unicode-org:main Nov 12, 2024
28 checks passed
@sffc sffc deleted the size_test_macro branch November 12, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sffc @Manishearth