Skip to content

CLDR-18405 fix links on downloads page #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

CLDR-18405 fix links on downloads page #4958

merged 1 commit into from
Oct 2, 2025

Conversation

DavidLRowe
Copy link
Contributor

CLDR-18405

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@DavidLRowe DavidLRowe requested a review from AEApple August 12, 2025 20:56
@github-actions GitHub Actions
Copy link

✨ This commit deployed to https://e28cf630.cldr.pages.dev
✨ This PR deployed to https://pr4958.cldr.pages.dev

Changed Pages in the last commit:

@github-actions github-actions bot added the Site Update Updates docs/site label Aug 12, 2025
AEApple
AEApple previously approved these changes Aug 12, 2025
View reviewed changes
DavidLRowe added a commit that referenced this pull request Aug 13, 2025
@DavidLRowe
CLDR-18405 fix links on downloads page
923daae 
See #4958
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@github-actions GitHub Actions
Copy link

✨ This commit deployed to https://9742c11f.cldr.pages.dev
✨ This PR deployed to https://pr4958.cldr.pages.dev

Changed Pages in the last commit:

@DavidLRowe
Copy link
Contributor Author

The "java" link produces a 404 not found (as it did before when redirected from the old branch). See question to @srl295 in the ticket.

srl295
srl295 previously approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we renamed 'java' to 'cldr-code' a long time ago

@DavidLRowe DavidLRowe dismissed stale reviews from srl295 and AEApple via a3fee20 October 1, 2025 18:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025

✨ This commit deployed to https://54c4f67c.cldr.pages.dev
✨ This PR deployed to https://pr4958.cldr.pages.dev

Changed Pages in the last commit:

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025

✨ This commit deployed to https://4076892d.cldr.pages.dev
✨ This PR deployed to https://pr4958.cldr.pages.dev

Changed Pages in the last commit:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025

✨ This commit deployed to https://0ee11698.cldr.pages.dev
✨ This PR deployed to https://pr4958.cldr.pages.dev

Changed Pages in the last commit:

@DavidLRowe
Copy link
Contributor Author

@srl295 I included your changes, and now need a re-approval. Thanks!

@DavidLRowe DavidLRowe merged commit 5038de4 into main Oct 2, 2025
18 checks passed
@DavidLRowe DavidLRowe deleted the CLDR-18405 branch October 2, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AEApple AEApple AEApple approved these changes

@srl295 srl295 srl295 left review comments

Assignees

@DavidLRowe DavidLRowe

Labels
Site Update Updates docs/site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidLRowe @srl295 @AEApple