Skip to content

Minor improvements & small bugs fixed #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Minor improvements & small bugs fixed #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccb14eb
Fix missing comma and name in scip.bzl
fzakaria Sep 12, 2025
708a4e0
Rename maven repository to be something more unique
fzakaria Sep 12, 2025
9726ea5
UPDATE README
fzakaria Sep 12, 2025
2090c64
Change repo name to be underscore
fzakaria Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module(
name = "scip-lsp",
name = "scip_lsp",
version = "0.1.0",
)

Expand All @@ -15,6 +15,7 @@ bazel_dep(name = "rules_proto", version = "7.0.2")
# Maven Deps
maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
maven.install(
name = "scip_lsp_maven",
artifacts = [
# SCIP Java dependencies
"com.sourcegraph:scip-java_2.13:0.10.4",
Expand Down Expand Up @@ -45,7 +46,7 @@ maven.install(

# Test dependencies - separate install to mark as testonly
maven.install(
name = "maven_test",
name = "scip_lsp_maven_test",
artifacts = [
"org.junit.jupiter:junit-jupiter-api:5.13.1",
"org.junit.jupiter:junit-jupiter-engine:5.13.1",
Expand All @@ -59,7 +60,7 @@ maven.install(
"https://repo1.maven.org/maven2/",
],
)
use_repo(maven, "maven", "maven_test")
use_repo(maven, "scip_lsp_maven", "scip_lsp_maven_test")

# Python toolchain setup
python = use_extension("@rules_python//python/extensions:python_toolchains.bzl", "python")
Expand Down
295 changes: 0 additions & 295 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 4 additions & 33 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,40 +64,11 @@ We will focus on a) automating these steps b) adjusting them to ensure they allo

3. [If Indexing Code in Another Repo] Add necessary dependencies to the repo's MODULE.bazel
```
bazel_dep(name = "rules_jvm_external", version = "6.7")
local_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:local.bzl", "local_repository")
local_repository(name = "scip_lsp", path = "/home/user/scip-lsp")

maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
maven.install(
artifacts = [
# SCIP Java dependencies
"com.sourcegraph:scip-java_2.13:0.10.4",
"com.sourcegraph:scip-semanticdb:0.10.4",
"com.sourcegraph:scip-java-proto:0.10.4",
"com.sourcegraph:semanticdb-java:0.10.4",
"com.sourcegraph:semanticdb-javac:0.10.4",

# Intellij dependencies
"com.jetbrains.intellij.java:java-decompiler-engine:jar:251.26094.121",

# Utility libraries
"commons-cli:commons-cli:1.5.0",
"commons-io:commons-io:2.11.0",
"org.jspecify:jspecify:0.3.0",
"org.ow2.asm:asm:9.7.1",
"org.projectlombok:lombok:1.18.38",

# Logging
"org.slf4j:slf4j-api:2.0.9",
"org.slf4j:slf4j-simple:2.0.9",
],
repositories = [
"https://repo1.maven.org/maven2/",
"https://www.jetbrains.com/intellij-repository/releases",
],
bazel_dep(name = "scip_lsp", version = "0.0.1")
local_path_override(
module_name = "scip_lsp",
path = "/path/to/code/uber/scip-lsp",
)
use_repo(maven, "maven")
```

4. SCIP Index Generation
Expand Down
Loading
Loading