Skip to content

Conversation

jeongyoonlee
Copy link
Collaborator

@jeongyoonlee jeongyoonlee commented May 16, 2025

Proposed changes

This PR fixes the build errors generated after #831, which removed the runtime dependency of Cython (e.g., here), by using pip install -e . instead of python setup.py build_ext --inplace in the GitHub Action files. The installation document has been updated accordingly.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the build setup by removing deprecated fetch_build_eggs() calls and updating how NumPy include paths are acquired, then bumps the package version.

  • Removed fetch_build_eggs() fallbacks for Cython and NumPy in setup.py
  • Switched from np_get_include() to np.get_include() with an import numpy as np
  • Updated version in pyproject.toml to 0.15.5dev

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
setup.py Dropped fetch_build_eggs logic, imported NumPy, updated include
pyproject.toml Bumped version from 0.15.4 to 0.15.5dev
Comments suppressed due to low confidence (3)

pyproject.toml:1

  • Add a [build-system] section in pyproject.toml (e.g., requires = ["setuptools>=61", "wheel", "cython<=0.29.34", "numpy"], build-backend = "setuptools.build_meta") so that Cython and NumPy are installed before building extensions.
[project]

pyproject.toml:3

  • [nitpick] The version string 0.15.5dev may not follow PEP 440 strict conventions; consider using 0.15.5.dev0 for a proper development release marker.
version = "0.15.5dev"

setup.py:47

  • [nitpick] The top-level include_dirs in setup() may be redundant since each Extension already specifies include_dirs; you can remove it to reduce duplication.
include_dirs=[np.get_include()],

@jeongyoonlee jeongyoonlee changed the title Remove deprecated fetch_build_eggs() in setup.py Fix build errors May 19, 2025
@jeongyoonlee jeongyoonlee requested a review from Copilot May 19, 2025 04:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR that fixes build errors by updating installation commands in GitHub Action files and the package setup.

  • Updates dependency fetching in setup.py to simplify use of Cython and numpy.
  • Revises installation commands in docs and CI workflows to use pip install -e . and support newer Python versions.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

File Description
setup.py Adjusts dependency fetching and installation settings for Cython and numpy.
pyproject.toml Updates package version to reflect development progress.
docs/installation.rst Revises installation instructions, removing deprecated build commands.
.github/workflows/* Updates Python version matrices and switches to pip install -e . for consistency.

@jeongyoonlee jeongyoonlee merged commit b981361 into master May 19, 2025
14 checks passed
@jeongyoonlee jeongyoonlee mentioned this pull request Jul 6, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants