Add optional chaining to delimiters #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A very unimportant pull request huh.
It's in the same category as the regular .
icecream17
added a commit
to icecream17/language-javascript
that referenced
this pull request
Feb 6, 2021
This is a visual commit. Really it's about precedence, how specific the selectors are. Since they're the same it should work no matter what. The reason ?. isn't detected is because of the parser itself. See https://github.com/jcs-PR/tree-sitter-javascript/pull/1/files and tree-sitter/tree-sitter-javascript#150
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional chaining and ...regular chaining should be in the same category