Skip to content

Conversation

developerjhp
Copy link
Contributor

Summary

Fixes #365

ADd <base> tag to resolve incorrect link generation in Giscus disscussions for the code-quality section.

Problem

  • Giscus was generating discussion links without the /code-quality/ base path
  • Links appeared as /code/examples/... instead of /code-quality/code/examples/...
  • This caused 404 errors when clicking links within discussions

- Add base href="/code-quality/" to fix incorrect link generation in GitHub Discussions
- Giscus was incorrectly parsing links in /code-quality/code/ structure
- Base tag ensures all relative links are correctly resolved with the module's base path
Copy link

vercel bot commented Sep 10, 2025

@developerjhp is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@milooy milooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milooy milooy merged commit 636a233 into toss:main Sep 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giscus discussion links are incorrectly generated for code-quality section pages
2 participants