Update documentation for route layer usage #3422
Open
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jul 30, 2025
| first add your routes and then call `route_layer` afterwards. Additional routes | ||
| added after `route_layer` is called will not have the middleware added. | ||
|
|
||
| **Important**: The middleware is NOT applied to fallback handlers. Fallback handlers |
There was a problem hiding this comment.
This paragraph is redundant with the one after it. Maybe that one isn't quite clear, but I don't think leaving it as-is and adding an extra one before it is the right fix. Can you think about how to merge these two paragraphs?
Comment on lines
+32
to
+37
| .fallback(|| async { "fallback" }) | ||
| .route_layer(ValidateRequestHeaderLayer::bearer("password")); | ||
|
|
||
| // `GET /foo` with a valid token will receive `200 OK` | ||
| // `GET /foo` with a invalid token will receive `401 Unauthorized` | ||
| // `GET /not-found` with a invalid token will receive `404 Not Found` | ||
| // `GET /not-found` with a invalid token will receive `200 OK` (fallback) |
There was a problem hiding this comment.
I don't think this example benefits from having an explicit fallback handler. Why did you add that? Maybe just add (default fallback handler) after the 404 Not Found?
|
Hey @omer9564, do you plan to get back to this and address the review feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3421