Skip to content

Conversation

otherJL0
Copy link
Contributor

@otherJL0 otherJL0 commented Mar 18, 2022

  • Fixed incorrectly indented return True line in by filter method in _info class methods
  • Created intermediate filtered list variables for _info class methods to more explicitly define the return type
  • Reduced nesting of if statements within class attached methods
  • Removed redundant int casts
  • Moved MutableMapping import statement from _compat to common

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #362 (f937e68) into master (2db8bba) will increase coverage by 0.00%.
The diff coverage is 82.85%.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files          15       15           
  Lines        1499     1500    +1     
=======================================
+ Hits         1319     1320    +1     
  Misses        180      180           
Impacted Files Coverage Δ
libtmux/common.py 87.25% <63.63%> (+0.12%) ⬆️
libtmux/session.py 81.32% <88.88%> (-0.12%) ⬇️
libtmux/window.py 84.75% <88.88%> (-0.10%) ⬇️
libtmux/pane.py 82.60% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db8bba...f937e68. Read the comment docs.

@tony
Copy link
Member

tony commented Mar 18, 2022

@otherJL0 Can you rebase against master?

@tony tony self-requested a review March 18, 2022 23:55
Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Rebased.

@tony tony merged commit eef13f8 into tmux-python:master Mar 18, 2022
tony added a commit that referenced this pull request Mar 18, 2022
@tony
Copy link
Member

tony commented Mar 19, 2022

@otherJL0 otherJL0 deleted the refactor-logic branch March 19, 2022 03:50
@tony
Copy link
Member

tony commented Mar 19, 2022

This is live in tmuxp v1.10 and libtmux and v0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants