Skip to content

Conversation

ritiek
Copy link
Contributor

@ritiek ritiek commented May 22, 2018

Closes #88.

This PR adds an optional parameter literal=False to Pane.send_keys which does not send keys to a tmux pane literally by default. When literal is set to True, it prefixes the send-keys command with -l parameter which allows sending keys literally.

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #121 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   79.49%   79.42%   -0.07%     
==========================================
  Files           8        8              
  Lines         863      865       +2     
==========================================
+ Hits          686      687       +1     
- Misses        177      178       +1
Impacted Files Coverage Δ
libtmux/pane.py 80.88% <75%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7027c...122d68e. Read the comment docs.

@tony
Copy link
Member

tony commented Oct 14, 2018

@ritiek Can you rebase this (so the tests again?)

@ritiek
Copy link
Contributor Author

ritiek commented Oct 14, 2018

Rebased. :)

@Seanmatthews
Copy link

Seems the only error for this was a timeout? Can we rerun the test?

@ritiek ritiek closed this Nov 17, 2018
@ritiek ritiek reopened this Nov 17, 2018
@ritiek
Copy link
Contributor Author

ritiek commented Nov 17, 2018

Ok, they passed.

@tony
Copy link
Member

tony commented Jan 13, 2019

@ritiek Can we add a test for this?

@tony tony merged commit d98f346 into tmux-python:master Jan 26, 2019
@tony
Copy link
Member

tony commented Jan 26, 2019

@ritiek merged! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not send-keys literally by default

4 participants