Skip to content

fix: configure snapcraft to build from git on main branch and limit job to it #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2025
Merged

fix: configure snapcraft to build from git on main branch and limit job to it #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8dd0f5
feat: build snap from working dir of repo
kbdharun Mar 27, 2025
958c956
fix: remove if condn from build
kbdharun Mar 27, 2025
89dabd4
test: build snap using git in main branch
kbdharun Mar 27, 2025
afb20ea
test: update snap workflow
kbdharun Mar 27, 2025
64619a0
fix: add missing man build
kbdharun Mar 27, 2025
dcfe398
feat: add back conditions to snap workflow
kbdharun Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ jobs:
id: snapcraft-build
with:
snapcraft-args: "-v"
path: "snap/test-snapcraft.yaml"

- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
Expand Down
2 changes: 0 additions & 2 deletions snap/snapcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,11 @@ parts:
tldr:
plugin: python
source: https://github.com/tldr-pages/tldr-python-client.git
source-tag: $SNAPCRAFT_PROJECT_VERSION
build-environment:
- PATH: ${CRAFT_PART_INSTALL}/bin:${PATH}
- PYTHONPATH: ${CRAFT_PART_INSTALL}/lib/python3.12/site-packages
override-pull: |
craftctl default
sed -i "/data_files=\[('share\/man\/man1', \['docs\/man\/tldr\.1'\])\],/d" setup.py
override-build: |
craftctl default
cd $CRAFT_PART_SRC/docs
Expand Down
76 changes: 0 additions & 76 deletions snap/test-snapcraft.yaml
View file
Open in desktop

This file was deleted.