Skip to content

Only require colorama on Windows #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2025
Merged

Only require colorama on Windows #266

merged 3 commits into from
Mar 27, 2025

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Jan 22, 2025

This removes the colorama dependency and import overhead on non-Windows platforms.

@kbdharun kbdharun self-assigned this Mar 27, 2025
kbdharun
kbdharun approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome to tldr and thanks for your contribution.

I have tested the changes locally. I am merging this PR now to be part of our upcoming release.

@kbdharun kbdharun merged commit 1a565b0 into tldr-pages:main Mar 27, 2025
16 checks passed
@hukkin hukkin deleted the colorama-win-only branch March 28, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

Assignees

@kbdharun kbdharun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hukkin @kbdharun