Skip to content

Conversation

CleanMachine1
Copy link
Member

closes #231

This is a really lazy fix for the issue, mainly since I am not 100% sure about all of the code.

Would appreciate some feedback.

@kbdharun kbdharun requested a review from vitorhcl May 9, 2024 13:24
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the changes. Tested it locally and this works much better than the previous broken approach.

@vitorhcl
Copy link
Member

I'll see if I can maybe review the code next week.

@kbdharun
Copy link
Member

kbdharun commented Jun 1, 2024

Hi @vitorhcl, Any updates on this?

@kbdharun kbdharun merged commit 3d78727 into main Jun 4, 2024
@kbdharun kbdharun deleted the search-fix branch June 4, 2024 04:17
@kbdharun kbdharun added this to the 3.3.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tldr --search "KEYWORDS" does not work
3 participants