Skip to content

Remove unimplemented fullDescription from TypeScript #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024
Merged

Remove unimplemented fullDescription from TypeScript #2191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,6 @@ export class Option {
*/
env(name: string): this;

/**
* Calculate the full description, including defaultValue etc.
*/
fullDescription(): string;

/**
* Set the custom handler for processing CLI option arguments into option values.
*/
Expand Down
3 changes: 0 additions & 3 deletions typings/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,9 +617,6 @@ expectType<commander.Option>(baseOption.preset('abc'));
// env
expectType<commander.Option>(baseOption.env('PORT'));

// fullDescription
expectType<string>(baseOption.fullDescription());

// argParser
expectType<commander.Option>(
baseOption.argParser((value: string) => parseInt(value)),
Expand Down