Check command-arguments even without action handler

[shadowspawn]

Pull Request

Problem

The number of command-arguments is only checked if there is an action handler. This means no checking for simple programs which fall-through to processing the results of the parsing in following code.

Fixes #1493

Solution

Follow in the footsteps of the refactored tests for options. Both the option and command-argument tests were originally tied to the implementation of the action handler. They have now been separated out to be called where appropriate.

Check for missing required command-arguments, or excess command-arguments if enabled, in programs without an action handler.

ChangeLog

• the number of command-arguments is now checked for programs without an action handler

[abetomo]

I commented on the naming, but the fix is LGTM.

[shadowspawn]

Note for future readers. Missing command-arguments will now cause an error whether or not there is an action handler. This changes the behaviour for simple single command programs.

program.argument('<file>');
program.parse();

$ pizza
error: missing required argument 'file'

If you want to just display the help if the user does not supply any arguments, you could check before calling parse like:

if (process.argv.length === 2) program.help();
program.parse();

Also, see .showHelpAfterError() to change the default behaviour to include extra help.