Add testing.T.Context() and testing.B.Context()
#5058
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-krieger
force-pushed
the
add-testing-context
branch
from
1bd0984 to
4c99a8d
Compare
ben-krieger
commented
Oct 1, 2025
| } | ||
|
|
||
| // Create a subtest. | ||
| ctx, cancelCtx := context.WithCancel(context.Background()) |
There was a problem hiding this comment.
It seems kinda weird that the parent context is not from the parent testing.T, but this seems to be how it is in the Go stdlib.
There was a problem hiding this comment.
Oh wait, there's specifically a comment on this in the Go stdlib:
There's no reason to inherit this context from parent. The user's code can't observe the difference between the background context and the one from the parent test.
|
As an alternative, it might be possible to switch to the standard library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches https://pkg.go.dev/testing#T.Context and https://pkg.go.dev/testing#B.Context