machine/usb/descriptor: refactor HID report descriptor creation #3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
changed the title
deadprogram
added a commit
to deadprogram/pico-ffb-steering-wheel
that referenced
this pull request
Apr 28, 2023
This is untested but should be more or less how to create HID report descriptors more easily using tinygo-org/tinygo#3693
|
I added one more commit to mare easily handle larger values, and to replace a bunch of "magic numbers" with const values. @sago35 please take a look. |
Signed-off-by: deadprogram <[email protected]>
…to create new descriptors in user code Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
usb-hid-report
branch
from
1888b57 to
ad0d090
Compare
|
Rebased against |
|
@sago35 did you have a chance to try this out yet? |
|
I can review tomorrow. Just give me a few minutes. |
sago35
approved these changes
May 5, 2023
|
Thank you for the review @sago35 now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the HID report descriptor creation in machine/usb/descriptor to make it a lot easier.
Note that this PR depends on #3692 which needs to be merged first and then this one rebased.