Skip to content

Add .cxx, .fvm files into .gitignore #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Add .cxx, .fvm files into .gitignore #25

merged 1 commit into from
Jul 16, 2025

Conversation

TaeBbong
Copy link
Contributor

Problem

  1. Quite a few flutter developers use fvm, which stands for flutter version manager. Related files are user-specified files, so we need to add into .gitignore.
  2. By flutter issue #163220, android/app/.cxx directory and including files were generated while running example app for android. (After flutter version 3.29, .cxx is default setup for .gitignore.)

Changes

  • Added following files into .gitignore
...

# Generated android build files(.cxx)
android/app/.cxx
example/android/app/.cxx

# fvmrc
.fvm
.fvmrc

@hermet hermet requested a review from Copilot July 14, 2025 14:33
Copilot
Copilot AI reviewed Jul 14, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@hermet hermet requested a review from tinyjin July 14, 2025 14:33
@hermet hermet added the infrastructure Dev infrastructure label Jul 14, 2025
tinyjin
tinyjin approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@tinyjin tinyjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinyjin tinyjin merged commit c005029 into thorvg:main Jul 16, 2025
@TaeBbong TaeBbong deleted the taebbong/gitignore branch July 16, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tinyjin tinyjin tinyjin approved these changes

Assignees

@TaeBbong TaeBbong

Labels
infrastructure Dev infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TaeBbong @tinyjin @hermet