Skip to content

Conversation

nicolasbeauvais
Copy link

Make laravel-langman work with lang files in subdirectories:

lang
  |_ en
      |_something
         |_file.php
  |_ fr
      |_something
         |_file.php

The file parsing (https://github.com/themsaid/laravel-langman/compare/master...nicolasbeauvais:langman-subdirectories?expand=1#diff-e07e4dbec2b7af0db87b7c9a92ddee86R61) could be improved with the new Str::before and Str::after methods but it would require illuminate/support:5.5 so I did it in a less fashionable way.

I renamed the $fileName var to $filePath as it makes more sense now.

I only had to change two lines of code to make it work, you made some very steady code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant