Skip to content

Conversation

pandafy
Copy link
Contributor

@pandafy pandafy commented Aug 12, 2025

After commit 7537fcb, field help text in Django 5.2 were rendered inside the flexbox container, causing it to appear on the same line as the field. This broke Django’s default layout convention, where help text is displayed below the field.

This patch moves the help text outside the flexbox container, restoring the expected layout.

After commit 7537fcb, field help
text in Django 5.2 were rendered inside the flexbox container,
causing it to appear on the same line as the field.
This broke Django’s default layout convention, where help text is
displayed below the field.

This patch moves the help text outside the flexbox container,
restoring the expected layout.
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.93%. Comparing base (34e513d) to head (61ec123).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files          20       20           
  Lines        2587     2587           
=======================================
  Hits         2042     2042           
  Misses        545      545           
Flag Coverage Δ
javascript 79.11% <ø> (ø)
python 78.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e513d...61ec123. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pandafy
Copy link
Contributor Author

pandafy commented Aug 12, 2025

I tested this patch in openwisp-monitoring where the CI started failing after upgrading to 4.1.2

Without the patch

Screenshot from 2025-08-12 17-31-47

With this patch

Screenshot from 2025-08-12 22-43-42

@fdintino
Copy link
Member

Yes, this was a mistake on my part. Thanks for the fix! I'll try to get it out in a release later today.

@fdintino fdintino merged commit 2286bda into theatlantic:master Aug 12, 2025
12 checks passed
@pandafy
Copy link
Contributor Author

pandafy commented Aug 12, 2025

Thank you for the prompt actions. 😄

@fdintino
Copy link
Member

I've just pushed the 4.1.3 release to PyPI.

@nemesifier
Copy link

Thanks @pandafy @fdintino 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants