Skip to content

Fixed sortable tabular inline visualization bug for view-only users #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed sortable tabular inline visualization bug for view-only users #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion nested_admin/templates/nesting/admin/inlines/tabular.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,13 @@ <h2 id="{{ inline_admin_formset.formset.prefix }}-heading" class="inline-heading
{% for fieldset in inline_admin_form %}
{% for line in fieldset %}
{% for field in line %}
{% if field.field.is_hidden %} {{ field.field }} {% endif %}
{% if field.field.is_hidden %}
{% if field.is_readonly %}
{{ field.form|get_field_instance:field.field.name }}
{% else %}
{{ field.field }}
{% endif %}
{% endif %}
{% endfor %}
{% endfor %}
{% endfor %}
Expand Down
5 changes: 5 additions & 0 deletions nested_admin/templatetags/nested_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,11 @@ def django_version_gte(string):
return django_version >= str_to_version(string)


@register.filter
def get_field_instance(fields_container, field_label):
return fields_container.__getitem__(field_label)


@register.tag
def ifinlineclasses(parser, token):
nodelist_true = parser.parse(("else", "endifinlineclasses"))
Expand Down
Loading