Skip to content

Conversation

antsmartian
Copy link
Collaborator

@antsmartian antsmartian commented Mar 29, 2018

What: A simple miss

Why: A simple bug :)

How: Added the necessary fix.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          72     72           
  Branches       17     17           
=====================================
  Hits           72     72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e8d45...012a59b. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper! Thanks!

@kentcdodds kentcdodds merged commit b13b1c1 into testing-library:master Mar 29, 2018
julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
* Add queryAll/getAll methods

Adds "all" methods for:
- byAltText
- byTestId

* Add tests for empty matches that return []

* Add contrib

* Add rest of getAll queries

* Document queryAll and getAll

* Make getAll throw when nothing matches

* Update docs on queryAll/getAll

* Refactor get* to use getAll*
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants