fix(types): make third and fourth params optional for findAllBy and findBy built queries #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indBy built queries
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9adb74:
|
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 725 725
Branches 188 190 +2
=========================================
Hits 725 725
Continue to review full report at Codecov.
|
|
@all-contributors please add @zorfling for code |
|
I've put up a pull request to add @zorfling! 🎉 |
|
🎉 This PR is included in version 7.26.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Updated types for built findBy / findAllBy custom queries and added extra type tests
Why: A fix made in PR #574 / Issue #534 added these parameters but accidentally made them required (see #574 (comment))
How: Updated the types in
query-helpers.d.tsto mimic the built-in types inqueries.d.ts, and added more type tests to ensure it won't regress.Checklist:
docs site N/A