Refactor README #63
Merged
Refactor README #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcrume
requested changes
Mar 4, 2017
README.md
Outdated
|
|
||
| ## Contributing | ||
| This project is not directly affiliated with the TensorFlow project, although we | ||
| do intend to communicate and cooperate with them. |
There was a problem hiding this comment.
This statement was true at one point, but the dividing line is blurrier now. It should probably be removed.
README.md
Outdated
| @@ -1,87 +1,105 @@ | |||
| #TensorFlow Rust | |||
| # <img src="https://www.tensorflow.org/images/tf_logo_transp.png" width="170"/> Rust Binding | |||
There was a problem hiding this comment.
Please provide alt text for the image.
| ## RFCs | ||
| RFCs are [issues tagged with RFC](https://github.com/tensorflow/rust/labels/rfc). | ||
| Check them out and comment. Discussions are welcome. After all, thats what a Request For Comment is for! | ||
| **OSX Note**: If you are running on OSX, there is a |
There was a problem hiding this comment.
Thanks for the OSX note. I only have Linux machines, so I need all the feedback from OSX and Windows users that I can get.
|
sorry for the delay, will fix it up tomorrow. |
closes tensorflow#52
|
@adamcrume updated based on your review |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #52
@adamcrume let me know if you are missing something, I tried to clean it up and put the beginner parts upfront. We currently don't have a "one liner example", so I just linked the example repo for now.