Skip to content

Change eager mode control inputs from exception to no-op, reflecting eager semantics. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Change eager mode control inputs from exception to no-op, reflecting eager semantics. #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb9929
Change eager mode control inputs from exception to no-op, reflecting …
rnett Nov 27, 2020
68927c2
fix test to reflect not throwing exception
rnett Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/EagerOperationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public EagerOperationBuilder addInputList(Output<?>[] inputs) {

@Override
public OperationBuilder addControlInput(Operation control) {
throw new UnsupportedOperationException(
"Control inputs are not supported in an eager execution environment");
// No-op. Any operations passed to this method will already be evaluated (b/c eager evaluation).
return this;
}

@Override
Expand Down
7 changes: 1 addition & 6 deletions ...flow-core/tensorflow-core-api/src/test/java/org/tensorflow/EagerOperationBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,7 @@ public void addInputs() {
.addInput(tf.constant(true).asOutput())
.addInputList(new Output<?>[] {tf.constant(-1).asOutput()})
.build();
try {
opBuilder(session, "Const", "var").addControlInput(asrt);
fail();
} catch (UnsupportedOperationException e) {
// expected
}
opBuilder(session, "Const", "var").addControlInput(asrt);
}
}

Expand Down