Skip to content

Conversation

rnett
Copy link
Contributor

@rnett rnett commented Nov 16, 2020

I adjust codegen to make ops group classes take Ops instead of Scope, get their Scope from it, save it in a field (ops), and provide an accessor for that field (ops()).

Fixes #147.

…ope, and get the scope from that. Save Ops parameter to field and add accessor for it.

Signed-off-by: Ryan Nett <[email protected]>
@google-cla
Copy link

google-cla bot commented Nov 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rnett
Copy link
Contributor Author

rnett commented Nov 16, 2020

@googlebot I signed it!

@karllessard karllessard merged commit 8c67a5a into tensorflow:master Nov 19, 2020
@karllessard
Copy link
Collaborator

Thanks for the contribution @rnett !

@rnett rnett deleted the rn_ops_ref branch December 5, 2020 04:41
rnett added a commit to rnett/tensorflow-java that referenced this pull request Dec 28, 2020
* Adjust sub-Ops classes to take Ops in their constructor instead of Scope, and get the scope from that.  Save Ops parameter to field and add accessor for it.

Signed-off-by: Ryan Nett <[email protected]>

* remove unlinked LinalgSparseOps

Signed-off-by: Ryan Nett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Ops class assessible from sub-ops classes (i.e. MathOps)
2 participants