Fix ruby2_keywords on Ruby 3.2 #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first versions of ruby that introduced ruby2_keywords had a small bug, only the first method in a chain of call needed to mark itself as using ruby2_keywords smeantic, e.g. ```ruby def foo(a:); end def bar(*args) foo(*args) end def baz(*args) bar(*args) end ruby2_keywords :baz baz(a: 1) ``` Up to 3.1 the above cause no issue, however in 3.2, `bar` also need to be marked with `ruby2_keywords`.
|
👋 @t6d any chance to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first versions of ruby that introduced ruby2_keywords had a small bug, only the first method in a chain of call needed to mark itself as using ruby2_keywords smeantic, e.g.
Up to 3.1 the above cause no issue,
however in 3.2,
baralso need to be marked withruby2_keywords.