Skip to content

Conversation

weaverryan
Copy link
Member

This temporarily embeds shellscape/webpack-manifest-plugin#249, which fixes #907 and also a comment on #914 (comment)

To test this:

$ yarn remove @symfony/webpack-encore
$ yarn add git://github.com/weaverryan/webpack-encore.git#try-manifest-fix

Please let me know if this does or doesn't fix your manifest.json file. I'm also interested in hearing from Windows users, as the fix requires some "path" manipulation.

Thanks!

@minimit
Copy link
Contributor

minimit commented Feb 8, 2021

Works great on mac, can't test on windows

@weaverryan
Copy link
Member Author

Thanks @shellscape for keeping an eye on that ;). I did include it in the new webpack-manifest-plugin directory - I grabbed the LICENSE file from master and put it there - https://github.com/symfony/webpack-encore/pull/921/files#diff-1422c8fd28cafc7a2c9bb9bfba27c0a1598d225ced0644653c1226bbd48604e7 - but let me know if it needs to be somewhere else.

Btw, this embedding I hope is temporary, at best :). I want to get the fix out to our users ASAP because I don't want users to start relying on the new incorrect paths... only for us to change them back later.

@weaverryan weaverryan force-pushed the try-manifest-fix branch 4 times, most recently from d3313e0 to 2552104 Compare February 9, 2021 02:19
@weaverryan weaverryan changed the title [WIP] Testing the webpack-manifest-plugin fix Fixing manifest paths (by temporarily embedding webpack-manifest-plugin fix) Feb 9, 2021
@weaverryan
Copy link
Member Author

This is now ready to go. We may never merge it - it depends on shellscape/webpack-manifest-plugin#249 - I'd like to merge and tag a fix ASAP for people. We could always remove this "embedded" plugin easily and re-add the real one.

Cheers!

@weaverryan weaverryan force-pushed the try-manifest-fix branch 4 times, most recently from 19e3bd9 to 6ae04be Compare February 11, 2021 02:03
@weaverryan
Copy link
Member Author

I've fully embedded the fix from shellscape/webpack-manifest-plugin#249

I'm confident that I now have the problem solved correctly there. I'd like to get this fix to our users, so I'm planning to merge this PR and temporarily embed the plugin so we can get it released :).

Cheers!

@weaverryan weaverryan merged commit 9847ea6 into symfony:main Feb 12, 2021
@weaverryan weaverryan deleted the try-manifest-fix branch February 12, 2021 00:09
Kocal added a commit that referenced this pull request Aug 3, 2025
…previously embedded in #921 (Kocal)

This PR was merged into the main branch.

Discussion
----------

Re-add `webpack-manifest-plugin` dependency, which was previously embedded in #921

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes <!-- please update CHANGELOG.md file -->
| Deprecations? | no <!-- please update CHANGELOG.md file -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Features and deprecations must be submitted against the latest branch.
 - For new features, provide some code snippets to help understand usage.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility.
-->

While working on #1381, I noticed that `lib/webpack-manifest-plugin/` was https://github.com/shellscape/webpack-manifest-plugin embedded with fix shellscape/webpack-manifest-plugin#249

The package was embedded because it was possible for the upstream PR to never be merged, but it has been merged and released.

We should not have any BCs from https://github.com/shellscape/webpack-manifest-plugin/releases

Commits
-------

d5d6b7b Re-add webpack-manifest-plugin as a dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.0 problems in manifest.json when importing from composer vendor folder
2 participants