Re-working dev-server and https detection #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2021
weaverryan
force-pushed
the
fixing-https-dev-server
branch
from
e38e681 to
86210d6
Compare
Kocal
reviewed
Feb 5, 2021
lib/config-generator.js
Outdated
| } | ||
| } | ||
|
|
||
| if (this.webpackConfig.useDevServer()) { |
There was a problem hiding this comment.
What about this, since we already check this.webpackConfig.useDevServer() before?
Suggested change
| if (this.webpackConfig.useDevServer()) { | |
| if (null !== devServerConfig) { |
If you pass --https at the command line, that overrides your
devServer.https config. In webpack-dev-server v3, that wasn't
a problem. But in v4, the certificate config was moved under devServer.https,
which can now be an object. This meant that if you passed --https at
the command line but also set devServer.https = { ... }, it would
be "re-set" back to "true" and your config would be lost.
The fix is to not require the --https flag and look at it or the user's
config to determine if the dev-server is running in https.
weaverryan
force-pushed
the
fixing-https-dev-server
branch
from
86210d6 to
ee417f0
Compare
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 8, 2021
This PR was merged into the 5.2 branch. Discussion ---------- [Encore] dev-server https fix updates See symfony/webpack-encore#917 Cheers! Commits ------- 7332254 Adding notes related to the dev-server https fix in Encore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Fixes #903
If you pass
--httpsat the command line, that overrides yourdevServer.httpsconfig. In webpack-dev-server v3, that wasn't a problem. But in v4, the certificate config was moved underdevServer.https, which can now be an object. This meant that if you passed--httpsat the command line (which Encore previously required) but also setdevServer.https = { ... }, that would be "re-set" back todevServer.https = trueand your config would be lost.The fix is to not require the
--httpsflag and look at it or the user's config to determine if the dev-server is running in https.Cheers!