Fix inability to use scss loader with Vue.js #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix when the less loader isn't enabled, the scss loader config is rewritten by mistake, leading to this error: > Module build failed: Error: Cannot process lang="less" inside src/js/Player.vue: the less-loader is not activated. I also fix a functional test case for Vue.js. Actually, the tests check if the first error thrown by webpack is about missing less loader. But the fixtures needs these loaders in the following order: scss, sass and finally less. Since there's no other loader than the VueJs one loaded in this test case, errors should be in the same order.
stof
approved these changes
Jul 12, 2017
|
Ah, thank you @NiR-! |
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2017
This PR was merged into the master branch. Discussion ---------- Fix inability to use scss loader with Vue.js Prior to this fix when the less loader isn't enabled, the scss loader config is rewritten by mistake, leading to this error: > Module build failed: Error: Cannot process lang="less" inside src/js/Player.vue: the less-loader is not activated. I also fix a functional test case for Vue.js. Actually, the tests check if the first error thrown by webpack is about missing less loader. But the fixtures needs these loaders in the following order: scss, sass and finally less. Since there's no other loader than the VueJs one loaded in this test case, errors should be in the same order. Commits ------- 2165a54 Fix inability to use scss loader with Vue.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix when the less loader isn't enabled, the scss loader config is rewritten by mistake, leading to this error:
I also fix a functional test case for Vue.js. Actually, the tests check if the first error thrown by webpack is about missing less loader. But the fixtures needs these loaders in the following order: scss, sass and finally less. Since there's no other loader than the VueJs one loaded in this test case, errors should be in the same order.