Skip to content

Reversing pathinfo logic to avoid extra comments #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Reversing pathinfo logic to avoid extra comments #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/config-generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class ConfigGenerator {
// will use the CDN path (if one is available) so that split
// chunks load internally through the CDN.
publicPath: this.webpackConfig.getRealPublicPath(),
pathinfo: this.webpackConfig.isProduction()
pathinfo: !this.webpackConfig.isProduction()
};
}

Expand Down
5 changes: 5 additions & 0 deletions test/functional.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,11 @@ describe('Functional tests using webpack', function() {
'main.js',
'// comments in no_require.js'
);
// check for any webpack-added comments
webpackAssert.assertOutputFileDoesNotContain(
'main.js',
'/*!'
);
// extra spaces should not live in the CSS file
webpackAssert.assertOutputFileDoesNotContain(
'styles.css',
Expand Down