Skip to content

Drop support of sass-loader ^13 and ^14, add support for sass-loader ^16 #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Drop support of sass-loader ^13 and ^14, add support for sass-loader ^16 #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,26 @@ This is a new major version that contains several backwards-compatibility breaks

* #1309 Drop ESLint integration (@Kocal)

* #1317 Drop support of sass-loader ^13 and ^14, add support for sass-loader ^16 (@Kocal)

The sass-loader's options have changed, [the `modern` options](https://sass-lang.com/documentation/js-api/interfaces/options) are now used by default.
Though not recommended,
you must specify the option `api: 'legacy'`
if you want to keep [the `legacy` options](https://sass-lang.com/documentation/js-api/interfaces/legacystringoptions/).
For example:
```js
// With the legacy API:
Encore.enableSassLoader((options) => {
options.api = 'legacy';
options.includePaths = [/*...*/];
});

// With the modern API (default):
Encore.enableSassLoader((options) => {
options.loadPaths = [/*...*/];
});
```

## 4.7.0

### Features
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"preact": "^10.5.0",
"preact-compat": "^3.17.0",
"sass": "^1.17.0",
"sass-loader": "^13.0.0 || ^14.0.0",
"sass-loader": "^16.0.1",
"sinon": "^14.0.0",
"strip-ansi": "^6.0.0",
"stylus": "^0.60.0",
Expand Down Expand Up @@ -120,7 +120,7 @@
"postcss": "^8.3.0",
"postcss-loader": "^7.0.0 || ^8.1.0",
"sass": "^1.17.0",
"sass-loader": "^13.0.0 || ^14.0.0",
"sass-loader": "^16.0.1",
"stylus": "^0.58.1",
"stylus-loader": "^7.0.0 || ^8.1.0",
"ts-loader": "^9.0.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6412,10 +6412,10 @@ safe-regex-test@^1.0.0:
resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a"
integrity sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==

"sass-loader@^13.0.0 || ^14.0.0":
version "14.0.0"
resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-14.0.0.tgz#fc8390f7cc16863622cd16f3ea07b36ba6ea8f91"
integrity sha512-oceP9wWbep/yRJ2+sMbCzk0UsXsDzdNis+N8nu9i5GwPXjy6v3DNB6TqfJLSpPO9k4+B8x8p/CEgjA9ZLkoLug==
sass-loader@^16.0.1:
version "16.0.1"
resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-16.0.1.tgz#57049c1787076e923b21a1dccc612546ecaf4295"
integrity sha512-xACl1ToTsKnL9Ce5yYpRxrLj9QUDCnwZNhzpC7tKiFyA8zXsd3Ap+HGVnbCgkdQcm43E+i6oKAWBsvGA6ZoiMw==
dependencies:
neo-async "^2.6.2"

Expand Down