Skip to content

Conversation

Lyrkan
Copy link
Contributor

@Lyrkan Lyrkan commented Oct 6, 2018

This PR adds some info about the configureRuntimeEnvironment(...) method of Encore.

I wasn't sure where to put that section, it's not an "advanced config" per-se, but it didn't feel right to add it to the FAQ either... but maybe that's just me?

Feature PR: symfony/webpack-encore#115
Closes: symfony/webpack-encore#233

@weaverryan
Copy link
Member

Thanks @Lyrkan!

@weaverryan weaverryan merged commit 24b3370 into symfony:3.4 Nov 16, 2018
weaverryan added a commit that referenced this pull request Nov 16, 2018
…onment method (Lyrkan, weaverryan)

This PR was merged into the 3.4 branch.

Discussion
----------

[Encore] Add a section about the configureRuntimeEnvironment method

This PR adds some info about the `configureRuntimeEnvironment(...)` method of Encore.

I wasn't sure where to put that section, it's not an "advanced config" per-se, but it didn't feel right to add it to the FAQ either... but maybe that's just me?

**Feature PR:** symfony/webpack-encore#115
**Closes:** symfony/webpack-encore#233

Commits
-------

24b3370 minor tweak
653ccff [Encore] Add a section about the configureRuntimeEnvironment method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants