Skip to content

Fix recursion in TypedArray initializer #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 21, 2021
Merged

Fix recursion in TypedArray initializer #142

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ca4302
Fix recursion in TypedArray initializer
PatrickPijnappel Nov 9, 2021
9187c48
Update tests, fix formatting
MaxDesiatov Nov 21, 2021
51f8441
Fix tests
MaxDesiatov Nov 21, 2021
cd5a483
Remove SwiftWasm 5.3.1 from GitHub Actions matrix
MaxDesiatov Nov 21, 2021
1ab9ea5
Use latest 5.5 snapshot on CI
MaxDesiatov Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/JavaScriptKit/BasicObjects/JSTypedArray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public class JSTypedArray<Element>: JSBridgedClass, ExpressibleByArrayLiteral wh
}

/// Convenience initializer for `Sequence`.
public convenience init<S: Sequence>(_ sequence: S) {
self.init(sequence.map({ $0 }))
public convenience init<S: Sequence>(_ sequence: S) where S.Element == Element {
self.init(Array(sequence))
}
}

Expand Down