Skip to content

Conversation

adam-fowler
Copy link
Contributor

No description provided.

@adam-fowler
Copy link
Contributor Author

@swift-server-bot test install please

@patrickfreed
Copy link
Contributor

@swift-server-bot add to allowlist

@patrickfreed
Copy link
Contributor

patrickfreed commented Apr 19, 2024

Thanks for updating these, definitely a good idea to do so before the release.

Could you run build_release.sh script against this branch (just pass update-package-versions as the first argument) and verify that the output of ldd swiftly indicates no new system dependencies were introduced? I'd do it myself, but I'm on a plane right now with very spotty wifi, so I don't think I'd be able to download the dependencies.

The existing release looks like the following:

$ ldd ~/.local/bin/swiftly
	linux-vdso.so.1 (0x00007ffc7dca9000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f44d1078000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f44d1055000)
	libutil.so.1 => /lib/x86_64-linux-gnu/libutil.so.1 (0x00007f44d1050000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f44d104a000)
	libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f44d0e68000)
	libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007f44d0e4c000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f44d0e2f000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f44d0c3d000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f44d49df000)

@adam-fowler
Copy link
Contributor Author

The build_release script doesn't appear to be working. Fails uname --machine

@patrickfreed
Copy link
Contributor

Hmm, I wonder if it needs to be run on Linux. It worked on my machine at least:

Step 10/10 : RUN ldd /swiftly
 ---> Running in f55ba0218265
	linux-vdso.so.1 (0x00007ffcae550000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f5807939000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f580771b000)
	libutil.so.1 => /lib64/libutil.so.1 (0x00007f5807518000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f5807314000)
	libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007f5806f92000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f5806d7d000)
	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f5806b67000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f58067ba000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f580b610000)

Dependencies look the same. I filed #99 to track the work for automating this step.

@patrickfreed patrickfreed merged commit 92339d6 into main Apr 23, 2024
@adam-fowler adam-fowler deleted the update-package-versions branch June 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants