Verify the libarchive payload #181
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libarchive that is used to make a swiftly release for Linux is downloaded directly from the libarchive project on GitHub from a release artifact. In theory, this release could become tampered in the future. Typically package managers get around this problem by both getting a specific version of the package, and also keep a hash/git commit to verify the contents. Add a content check using an expected SHA-256 sum of the release source tarball of libarchive to help protect against any tampering of the release in the future.
|
@swift-ci test macOS |
justice-adams-apple
approved these changes
Nov 4, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libarchive that is used to make a swiftly release for Linux is downloaded directly from the libarchive project on GitHub from a release artifact. In theory, this release could become tampered in the future.
Typically package managers get around this problem by both getting a specific version of the package, and also keep a hash/git commit to verify the contents.
Add a content check using an expected SHA-256 sum of the release source tarball of libarchive to help protect against any tampering of the release in the future.